From 4469c02191c6432efb5a09733575ca02d329d575 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arno=C5=A1t=20Pleskot?= Date: Tue, 1 Aug 2023 16:52:59 +0200 Subject: [PATCH] chore: move this.scene.getElementsIncludingDeleted() result into const --- src/components/App.tsx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/components/App.tsx b/src/components/App.tsx index 1889a1f7b..7b8c49217 100644 --- a/src/components/App.tsx +++ b/src/components/App.tsx @@ -1866,10 +1866,8 @@ class App extends React.Component { componentDidUpdate(prevProps: AppProps, prevState: AppState) { this.updateEmbeddables(); - if ( - !this.state.showWelcomeScreen && - !this.scene.getElementsIncludingDeleted().length - ) { + const elementsIncludingDeleted = this.scene.getElementsIncludingDeleted(); + if (!this.state.showWelcomeScreen && !elementsIncludingDeleted.length) { this.setState({ showWelcomeScreen: true }); } @@ -2058,7 +2056,7 @@ class App extends React.Component { isViewportOutsideOfConstrainedArea && this.state.cursorButton !== "down" && prevState.zoom.value === this.state.zoom.value && - this.scene.getElementsIncludingDeleted().length > 0, // Do not animate when app is initialized but scene is empty - this would cause flickering + elementsIncludingDeleted.length > 0, // Do not animate when app is initialized but scene is empty - this would cause flickering }); }